paleolimbot commented on code in PR #39148: URL: https://github.com/apache/arrow/pull/39148#discussion_r1424174402
########## r/bootstrap.R: ########## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +if (!dir.exists('../cpp')) { + cli::cli_alert_warning("Arrow C++ sources not found, skipping bootstrap.") + q(save = "no") Review Comment: pkgbuild doesn't error for anything that happens in bootstrap.R...`configure` would be the correct place to ensure the tarball was built properly. (However, since we have build-ignored bootstrap.R, it will also never run when `../cpp` doesn't exist). I do think that `q()` is anti-social here...the logical way most contributors would contribute to and interactively debug this is in RStudio and by `source()`ing it. The current script will close the RStudio window and nix all data in the user session without any indication as to why, which I think we should avoid unless absolutely necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
