paleolimbot commented on PR #39148: URL: https://github.com/apache/arrow/pull/39148#issuecomment-1848610895
> Ah yes that sounds useful, so we want to change it to always vendor the cpp source Yes! bootstrap.R is the *only* file where this can happen that's guaranteed to run during `pkgbuild::build()`. Moving that logic there is the only way to ensure that installation from developer/package install tools that use `pkgbuild::build()` will get the same tarball as the one we would release to CRAN. > only do the other release stuff on release version/opt-in. I would say that automating all those steps is a good thing, but bootstrap.R is not the file to do it. These steps aren't things that you want to fail during package installation via `pak::pak()`, for example...you really just want to do them on a release branch and then commit the result. > why install a release version from gh instead of CRAN? This mostly matters before we have released it to CRAN (allows, for example, that I or somebody could quickly install the about-to-be-released tarball to ensure that it fixed some problem). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
