lidavidm commented on code in PR #38371:
URL: https://github.com/apache/arrow/pull/38371#discussion_r1425419840
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowFileWriter.java:
##########
@@ -76,15 +74,8 @@ public ArrowFileWriter(VectorSchemaRoot root,
DictionaryProvider provider, Writa
}
public ArrowFileWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out,
- Map<String, String> metaData, IpcOption option,
CompressionCodec.Factory compressionFactory,
- CompressionUtil.CodecType codecType) {
- this(root, provider, out, metaData, option, compressionFactory, codecType,
Optional.empty());
- }
-
- public ArrowFileWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out,
- Map<String, String> metaData, IpcOption option,
CompressionCodec.Factory compressionFactory,
- CompressionUtil.CodecType codecType,
Optional<Integer> compressionLevel) {
- super(root, provider, out, option, compressionFactory, codecType,
compressionLevel);
+ Map<String, String> metaData, IpcOption option, CompressionCodec codec) {
Review Comment:
Isn't this removing a public constructor?
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowWriter.java:
##########
@@ -82,22 +81,16 @@ protected ArrowWriter(VectorSchemaRoot root,
DictionaryProvider provider, Writab
* @param provider where to find the dictionaries
* @param out the output where to write
* @param option IPC write options
- * @param compressionFactory Compression codec factory
- * @param codecType Compression codec
- * @param compressionLevel Compression level
+ * @param codec the compression codec
*/
- protected ArrowWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out, IpcOption option,
- CompressionCodec.Factory compressionFactory,
CompressionUtil.CodecType codecType,
- Optional<Integer> compressionLevel) {
Review Comment:
This is changing a constructor signature?
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowStreamWriter.java:
##########
@@ -82,33 +80,13 @@ public ArrowStreamWriter(VectorSchemaRoot root,
DictionaryProvider provider, Wri
* @param root Existing VectorSchemaRoot with vectors to be written.
* @param provider DictionaryProvider for any vectors that are dictionary
encoded.
* (Optional, can be null)
- * @param option IPC write options
- * @param compressionFactory Compression codec factory
- * @param codecType Codec type
* @param out WritableByteChannel for writing.
- */
- public ArrowStreamWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out,
- IpcOption option, CompressionCodec.Factory
compressionFactory,
- CompressionUtil.CodecType codecType) {
- this(root, provider, out, option, compressionFactory, codecType,
Optional.empty());
- }
Review Comment:
Isn't this also removing a constructor?
##########
java/compression/src/test/java/org/apache/arrow/compression/TestArrowReaderWriterWithCompression.java:
##########
@@ -18,31 +18,71 @@
package org.apache.arrow.compression;
import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.FileOutputStream;
import java.nio.channels.Channels;
+import java.nio.channels.FileChannel;
+import java.nio.channels.SeekableByteChannel;
+import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Optional;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.memory.RootAllocator;
+import org.apache.arrow.vector.FieldVector;
import org.apache.arrow.vector.GenerateSampleData;
+import org.apache.arrow.vector.VarCharVector;
import org.apache.arrow.vector.VectorSchemaRoot;
import org.apache.arrow.vector.compression.CompressionUtil;
import org.apache.arrow.vector.compression.NoCompressionCodec;
+import org.apache.arrow.vector.dictionary.Dictionary;
+import org.apache.arrow.vector.dictionary.DictionaryEncoder;
+import org.apache.arrow.vector.dictionary.DictionaryProvider;
import org.apache.arrow.vector.ipc.ArrowFileReader;
import org.apache.arrow.vector.ipc.ArrowFileWriter;
+import org.apache.arrow.vector.ipc.ArrowStreamReader;
+import org.apache.arrow.vector.ipc.ArrowStreamWriter;
import org.apache.arrow.vector.ipc.message.IpcOption;
import org.apache.arrow.vector.types.pojo.ArrowType;
+import org.apache.arrow.vector.types.pojo.DictionaryEncoding;
import org.apache.arrow.vector.types.pojo.Field;
import org.apache.arrow.vector.types.pojo.FieldType;
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.arrow.vector.util.ByteArrayReadableSeekableByteChannel;
+import org.junit.After;
import org.junit.Assert;
+import org.junit.Before;
import org.junit.Test;
public class TestArrowReaderWriterWithCompression {
+ private BufferAllocator allocator;
+ private VarCharVector dictionaryVector1;
+ private Dictionary dictionary1;
+ @Before
Review Comment:
This is unaddressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
