vibhatha commented on code in PR #38371:
URL: https://github.com/apache/arrow/pull/38371#discussion_r1425546138
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowFileWriter.java:
##########
@@ -76,15 +74,8 @@ public ArrowFileWriter(VectorSchemaRoot root,
DictionaryProvider provider, Writa
}
public ArrowFileWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out,
- Map<String, String> metaData, IpcOption option,
CompressionCodec.Factory compressionFactory,
- CompressionUtil.CodecType codecType) {
- this(root, provider, out, metaData, option, compressionFactory, codecType,
Optional.empty());
- }
-
- public ArrowFileWriter(VectorSchemaRoot root, DictionaryProvider provider,
WritableByteChannel out,
- Map<String, String> metaData, IpcOption option,
CompressionCodec.Factory compressionFactory,
- CompressionUtil.CodecType codecType,
Optional<Integer> compressionLevel) {
- super(root, provider, out, option, compressionFactory, codecType,
compressionLevel);
+ Map<String, String> metaData, IpcOption option, CompressionCodec codec) {
Review Comment:
@lidavidm for my clarification.
Maybe I have misunderstood your comment
[here](https://github.com/apache/arrow/pull/38371#discussion_r1406578274).
I thought it would be rather cleaner to pass the `CompressionCodec` rather
than passing all the other parameters which make this object.
Did you mean something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
