devinjdangelo commented on code in PR #8539: URL: https://github.com/apache/arrow-datafusion/pull/8539#discussion_r1426845928
########## datafusion/sqllogictest/test_files/insert_to_external.slt: ########## @@ -57,7 +57,7 @@ CREATE EXTERNAL TABLE dictionary_encoded_parquet_partitioned( b varchar, ) STORED AS parquet -LOCATION 'test_files/scratch/insert_to_external/parquet_types_partitioned' +LOCATION 'test_files/scratch/insert_to_external/parquet_types_partitioned/' Review Comment: Now that inserting (appending) to an individual file is no longer a thing `ListingTable` needs to concern itself with, I wonder if the concept of a "single file" table could be completely removed. I.e. whether there is a trailing slash or not, the `LOCATION` is interpreted as the directory where the data files will be written to / read from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
