alamb commented on code in PR #8539:
URL: https://github.com/apache/arrow-datafusion/pull/8539#discussion_r1427008122
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -148,19 +148,18 @@ impl TableProviderFactory for ListingTableFactory {
.unwrap_or(false)
};
- let create_local_path = statement_options
- .take_bool_option("create_local_path")?
- .unwrap_or(false);
let single_file = statement_options
.take_bool_option("single_file")?
.unwrap_or(false);
// Backwards compatibility
if let Some(s) = statement_options.take_str_option("insert_mode") {
if !s.eq_ignore_ascii_case("append_new_files") {
- return plan_err!("Unknown or unsupported insert mode {s}. Only
append_to_file supported");
+ return plan_err!("Unknown or unsupported insert mode {s}. Only
append_new_files supported");
}
}
+ statement_options.take_bool_option("create_local_path")?;
Review Comment:
Can we please leave an comment here explaining why this is being ignored?
Maybe even with a ticket reference to a ticket tracking removing it?
I can file such a ticket if it would be helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
