alamb commented on PR #8511: URL: https://github.com/apache/arrow-datafusion/pull/8511#issuecomment-1856524258
I ran benchmarks and my conclusion is that this branch doesn't change the performance and any changes are within the level of noise ``` -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ bugfix_count-null ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 3.64ms │ 3.74ms │ no change │ │ QQuery 1 │ 135.02ms │ 138.12ms │ no change │ │ QQuery 2 │ 299.58ms │ 312.29ms │ no change │ │ QQuery 3 │ 280.64ms │ 293.30ms │ no change │ │ QQuery 4 │ 2783.49ms │ 2773.07ms │ no change │ │ QQuery 5 │ 4050.48ms │ 3897.47ms │ no change │ │ QQuery 6 │ 125.78ms │ 123.34ms │ no change │ │ QQuery 7 │ 140.97ms │ 141.36ms │ no change │ │ QQuery 8 │ 4433.68ms │ 4286.59ms │ no change │ │ QQuery 9 │ 7768.12ms │ 7501.32ms │ no change │ │ QQuery 10 │ 1120.87ms │ 1073.25ms │ no change │ │ QQuery 11 │ 1206.52ms │ 1178.95ms │ no change │ │ QQuery 12 │ 3528.50ms │ 3434.86ms │ no change │ │ QQuery 13 │ 6754.81ms │ 6778.36ms │ no change │ │ QQuery 14 │ 3859.19ms │ 3913.48ms │ no change │ │ QQuery 15 │ 3078.75ms │ 3047.18ms │ no change │ │ QQuery 16 │ 8303.34ms │ 8266.43ms │ no change │ │ QQuery 17 │ 7910.97ms │ 7943.00ms │ no change │ │ QQuery 18 │ 16263.82ms │ 15770.30ms │ no change │ │ QQuery 19 │ 235.28ms │ 228.10ms │ no change │ │ QQuery 20 │ 3989.39ms │ 3658.45ms │ +1.09x faster │ │ QQuery 21 │ 4972.73ms │ 4778.85ms │ no change │ │ QQuery 22 │ 13516.67ms │ 13320.12ms │ no change │ │ QQuery 23 │ 35451.65ms │ 33649.33ms │ +1.05x faster │ │ QQuery 24 │ 1885.83ms │ 1919.50ms │ no change │ │ QQuery 25 │ 1630.22ms │ 1604.27ms │ no change │ │ QQuery 26 │ 2034.69ms │ 2042.98ms │ no change │ │ QQuery 27 │ 5236.29ms │ 5144.58ms │ no change │ │ QQuery 28 │ 42455.40ms │ 41939.68ms │ no change │ │ QQuery 29 │ 1493.39ms │ 1500.64ms │ no change │ │ QQuery 30 │ 3408.16ms │ 3666.76ms │ 1.08x slower │ │ QQuery 31 │ 4357.88ms │ 4430.19ms │ no change │ │ QQuery 32 │ 23382.55ms │ 22710.19ms │ no change │ │ QQuery 33 │ 18094.43ms │ 17377.25ms │ no change │ │ QQuery 34 │ 19085.58ms │ 18796.15ms │ no change │ │ QQuery 35 │ 5181.19ms │ 5264.16ms │ no change │ │ QQuery 36 │ 697.38ms │ 730.89ms │ no change │ │ QQuery 37 │ 368.22ms │ 392.02ms │ 1.06x slower │ │ QQuery 38 │ 324.24ms │ 325.51ms │ no change │ │ QQuery 39 │ 1643.98ms │ 1595.20ms │ no change │ │ QQuery 40 │ 186.05ms │ 176.14ms │ +1.06x faster │ │ QQuery 41 │ 165.92ms │ 146.29ms │ +1.13x faster │ │ QQuery 42 │ 174.23ms │ 171.96ms │ no change │ └──────────────┴────────────┴───────────────────┴───────────────┘ ``` ``` -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ bugfix_count-null ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 345.57ms │ 337.26ms │ no change │ │ QQuery 2 │ 85.16ms │ 80.29ms │ +1.06x faster │ │ QQuery 3 │ 193.96ms │ 190.57ms │ no change │ │ QQuery 4 │ 197.21ms │ 201.03ms │ no change │ │ QQuery 5 │ 333.08ms │ 339.23ms │ no change │ │ QQuery 6 │ 37.63ms │ 35.96ms │ no change │ │ QQuery 7 │ 890.08ms │ 881.96ms │ no change │ │ QQuery 8 │ 172.86ms │ 167.49ms │ no change │ │ QQuery 9 │ 192.89ms │ 200.49ms │ no change │ │ QQuery 10 │ 393.93ms │ 403.95ms │ no change │ │ QQuery 11 │ 66.91ms │ 65.34ms │ no change │ │ QQuery 12 │ 231.26ms │ 239.59ms │ no change │ │ QQuery 13 │ 173.97ms │ 172.41ms │ no change │ │ QQuery 14 │ 71.21ms │ 71.20ms │ no change │ │ QQuery 15 │ 224.79ms │ 225.91ms │ no change │ │ QQuery 16 │ 79.26ms │ 76.84ms │ no change │ │ QQuery 17 │ 228.44ms │ 238.25ms │ no change │ │ QQuery 18 │ 762.62ms │ 806.16ms │ 1.06x slower │ │ QQuery 19 │ 114.11ms │ 122.09ms │ 1.07x slower │ │ QQuery 20 │ 267.40ms │ 271.21ms │ no change │ │ QQuery 21 │ 1017.97ms │ 1032.86ms │ no change │ │ QQuery 22 │ 49.09ms │ 56.83ms │ 1.16x slower │ └──────────────┴───────────┴───────────────────┴───────────────┘ alamb@aal-dev:~/datafusion-benchmarking$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
