kylebarron commented on code in PR #35780:
URL: https://github.com/apache/arrow/pull/35780#discussion_r1428641669
##########
js/src/enum.ts:
##########
@@ -175,6 +174,7 @@ export enum Type {
FixedSizeList = 16, /** Fixed-size list. Each value occupies the same
number of bytes */
Map = 17, /** Map of named logical types */
Duration = 18, /** Measure of elapsed time in either seconds,
milliseconds, microseconds or nanoseconds. */
+ LargeUtf8 = 20, /** Large variable-length string as List<Char> */
Review Comment:
Did you skip 19 on purpose?
##########
js/src/util/buffer.ts:
##########
@@ -208,10 +208,12 @@ export async function* toArrayBufferViewAsyncIterator<T
extends TypedArray>(Arra
/** @ignore */ export const toUint8ClampedArrayAsyncIterator = (input:
ArrayBufferViewAsyncIteratorInput) =>
toArrayBufferViewAsyncIterator(Uint8ClampedArray, input);
/** @ignore */
-export function rebaseValueOffsets(offset: number, length: number,
valueOffsets: Int32Array) {
+export function rebaseValueOffsets(offset: number, length: number,
valueOffsets: Int32Array): Int32Array;
+export function rebaseValueOffsets(offset: bigint, length: number,
valueOffsets: BigInt64Array): BigInt64Array;
+export function rebaseValueOffsets(offset: number | bigint, length: number,
valueOffsets: any) {
// If we have a non-zero offset, create a new offsets array with the values
// shifted by the start offset, such that the new start offset is 0
- if (offset !== 0) {
+ if (offset != 0) {
Review Comment:
is this necessary to compare the bigint to a number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
