kou commented on code in PR #39098: URL: https://github.com/apache/arrow/pull/39098#discussion_r1428838772
########## cpp/src/gandiva/engine.cc: ########## @@ -86,6 +88,13 @@ #include <llvm/Transforms/Utils.h> #include <llvm/Transforms/Vectorize.h> +// JITLink is available in LLVM 9+ +// but the `InProcessMemoryManager::Create` API was added since LLVM 14 +#if LLVM_VERSION_MAJOR >= 14 && !defined(_WIN32) && !defined(_WIN64) Review Comment: Hmm. I think that we can skip all Windows with just `!defined(_WIN32)`. Because `_WIN32` is defined on 64bit Windows too. https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 > `_WIN32` Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
