niyue commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1428846258
##########
cpp/src/gandiva/configuration.h:
##########
@@ -65,6 +71,9 @@ class GANDIVA_EXPORT Configuration {
bool target_host_cpu_; /* set the mcpu flag to host cpu while compiling llvm
ir */
std::shared_ptr<FunctionRegistry>
function_registry_; /* function registry that may contain external
functions */
+ // flag indicating if IR dumping is needed, defaults to false, and turning
it on will
+ // negatively affect performance
+ bool needs_ir_dumping_ = false;
Review Comment:
Not problem. I don't like the prefix but I am not sure if `dump_ir` is too
simple. Renamed them all to use `dump_ir`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
