clbarnes commented on PR #5206: URL: https://github.com/apache/arrow-rs/pull/5206#issuecomment-1859133181
And before I go through all the implementations again, for the sake of object safety would you prefer `get_range` to take the new `HttpRange` object directly rather than taking `T: Into<HttpRange>` (which would allow people to continue to pass in `Range`s)? I have a preference for reading the `GetResult.range` from the response headers if available rather than assuming it's the same as the request, because (especially for the raw HTTP case) it's not impossible that the server sends us something weird and users should know about it sooner rather than later. Because we know the resource length at that point, we can use a std `Range` there. This would also allow us to recover from a 200 (we just slice the whole response) although an error is probably more correct there because we don't want users to be accidentally fetching the whole resource over and over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
