clbarnes commented on PR #5206:
URL: https://github.com/apache/arrow-rs/pull/5206#issuecomment-1860070405

   > get_ranges, in particular colaesce_ranges, won't work with partial ranges.
   
   I have an implementation of coalesce_ranges which uses the new struct. 
There's a helper function which returns `(Vec<HttpRange::Range | 
HttpRange::Offset>, Option<HttpRange::Suffix>)`, and so could feasibly cover 
the same bytes twice but that's on the user. 
   
   > This will also avoid breaking existing code that uses get_range/get_ranges.
   
   Should be fine, I can see the `GetResult` has public methods for easily 
getting the `Bytes` out of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to