zanmato1984 commented on code in PR #39267:
URL: https://github.com/apache/arrow/pull/39267#discussion_r1429582083
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -240,7 +240,7 @@ struct Month {
// ----------------------------------------------------------------------
// Extract day from temporal types
-template <typename Duration, typename Localizer>
+template <typename Duration, typename Localizer, typename = void*>
Review Comment:
Add a third type parameter to distinguish `DurationType` from others.
Defaults to `void *` so the existing `TemporalComponentExtractBase`s and other
kernels that don't have `DurationType` overloads don't have to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
