zanmato1984 commented on code in PR #39267:
URL: https://github.com/apache/arrow/pull/39267#discussion_r1429583814
##########
cpp/src/arrow/compute/kernels/temporal_internal.h:
##########
@@ -269,6 +283,18 @@ struct TemporalComponentExtractBase<Op,
std::chrono::seconds, Time32Type, OutTyp
}
};
+template <template <typename...> class Op, typename OutType>
+struct TemporalComponentExtractBase<Op, std::chrono::seconds, DurationType,
OutType> {
+ template <typename OptionsType>
+ static Status ExecWithOptions(KernelContext* ctx, const OptionsType* options,
+ const ExecSpan& batch, ExecResult* out) {
+ using ExecTemplate = Op<std::chrono::seconds, NonZonedLocalizer,
DurationType>;
Review Comment:
Here the `DurationType` is explicitly specified as the third type parameter
so it goes to the corresponding specification. And the following similar
changes are at the same essence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
