zanmato1984 commented on PR #39267: URL: https://github.com/apache/arrow/pull/39267#issuecomment-1861204905
> @pitrou could you please take a look at the proposed template changes? Alternatively, I can make the overloads of `day/second/millisecond/microsecond/nanosecond/subsecond` new functions, by registering them with special function names, e.g. `xxx_from_duration`. This way the template change could be minimal, at the cost of extra boilerplate code for new function and possibly Python binding changes, i.e., Python attribute access of `seconds` for a underlying duration array should call C++ `second_from_duration` instead of `second`. Personally I think the overload way (the present one in this PR) might make more sense, but I could be wrong. I'm open to any comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
