viirya commented on code in PR #8578:
URL: https://github.com/apache/arrow-datafusion/pull/8578#discussion_r1430587982
##########
datafusion/expr/src/udf.rs:
##########
@@ -79,7 +90,11 @@ impl std::hash::Hash for ScalarUDF {
}
impl ScalarUDF {
- /// Create a new ScalarUDF
+ /// Create a new ScalarUDF from low level details.
+ ///
+ /// See [`ScalarUDFImpl`] for a more convenient way to create a
+ /// `ScalarUDF` using trait objects
+ #[deprecated(since = "34.0.0", note = "please implement ScalarUDFImpl
instead")]
Review Comment:
Agreed that current low-level API looks awkward to use. Ideally a trait
defining what a UDF should implement should be better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
