alamb commented on code in PR #8578:
URL: https://github.com/apache/arrow-datafusion/pull/8578#discussion_r1430520598
##########
datafusion/expr/src/udf.rs:
##########
@@ -79,7 +90,11 @@ impl std::hash::Hash for ScalarUDF {
}
impl ScalarUDF {
- /// Create a new ScalarUDF
+ /// Create a new ScalarUDF from low level details.
+ ///
+ /// See [`ScalarUDFImpl`] for a more convenient way to create a
+ /// `ScalarUDF` using trait objects
+ #[deprecated(since = "34.0.0", note = "please implement ScalarUDFImpl
instead")]
Review Comment:
I think this low level API is quite akward to use and very hard to extend in
backwards compatible ways. The trait is easer to use and easier to extend.
Thus I propose marking this API as deprecated (note most of the examples in
codebase use `create_udf` rather than `ScalarUDF:new()` directly) so I think
the impact will be limited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
