mustafasrepo commented on PR #8558: URL: https://github.com/apache/arrow-datafusion/pull/8558#issuecomment-1862828753
I ran the benchmark. It seems that there is no noticable difference between main and this branch ``` Comparing apache_main and feature_conflicting_order_sensitive_aggregates -------------------- Benchmark tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ apache_main ┃ feature_conflicting_order_sensitive_aggregates ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 155.03ms │ 155.11ms │ no change │ │ QQuery 2 │ 51.29ms │ 50.19ms │ no change │ │ QQuery 3 │ 70.80ms │ 70.74ms │ no change │ │ QQuery 4 │ 53.50ms │ 52.49ms │ no change │ │ QQuery 5 │ 83.31ms │ 81.72ms │ no change │ │ QQuery 6 │ 32.21ms │ 34.44ms │ 1.07x slower │ │ QQuery 7 │ 110.54ms │ 108.78ms │ no change │ │ QQuery 8 │ 107.96ms │ 105.57ms │ no change │ │ QQuery 9 │ 131.45ms │ 129.97ms │ no change │ │ QQuery 10 │ 138.69ms │ 136.58ms │ no change │ │ QQuery 11 │ 53.11ms │ 37.97ms │ +1.40x faster │ │ QQuery 12 │ 88.59ms │ 87.70ms │ no change │ │ QQuery 13 │ 193.31ms │ 193.14ms │ no change │ │ QQuery 14 │ 52.28ms │ 50.66ms │ no change │ │ QQuery 15 │ 63.30ms │ 63.46ms │ no change │ │ QQuery 16 │ 56.69ms │ 55.70ms │ no change │ │ QQuery 17 │ 114.69ms │ 114.89ms │ no change │ │ QQuery 18 │ 198.72ms │ 201.31ms │ no change │ │ QQuery 19 │ 99.40ms │ 98.48ms │ no change │ │ QQuery 20 │ 58.72ms │ 61.62ms │ no change │ │ QQuery 21 │ 133.12ms │ 137.09ms │ no change │ │ QQuery 22 │ 39.80ms │ 40.91ms │ no change │ └──────────────┴─────────────┴────────────────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (apache_main) │ 2086.50ms │ │ Total Time (feature_conflicting_order_sensitive_aggregates) │ 2068.53ms │ │ Average Time (apache_main) │ 94.84ms │ │ Average Time (feature_conflicting_order_sensitive_aggregates) │ 94.02ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 20 │ └───────────────────────────────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
