alamb commented on PR #8558: URL: https://github.com/apache/arrow-datafusion/pull/8558#issuecomment-1866884647
I am hesitant to make the Hash Aggregate stream any more complex than it already is -- so therefore I am worried about this PR. I think @mustafasrepo has shown the performance does not change, which is good. However, can you please review the contents of https://github.com/apache/arrow-datafusion/issues/8582 before proceeding with this PR. I feel like we can likely make most queries faster with less complicated code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
