Tom-Newton commented on PR #39298: URL: https://github.com/apache/arrow/pull/39298#issuecomment-1863638680
> @Tom-Newton This split caused 2 `ExceptionToStatus` functions to exist and would force me to expose `IsDfsEmulator` and `IsContainerNotFound` in the `azurefs_internal.h` header since I need them to implement the HNS check and other filesystem operations that now live in `azurefs.cc`. I'm not opposed to partitioning `azurefs.cc` into smaller files, but that split should be one that minimizes the shared interfaces between the partitions that have to be announced in a header -- a more natural split will be more evident when we finish the implementation. I think personally I would have moved `IsDfsEmulator` and `IsContainerNotFound` in the `azurefs_internal.h` but I don't feel strongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
