Tom-Newton commented on code in PR #39298:
URL: https://github.com/apache/arrow/pull/39298#discussion_r1432053025
##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -117,6 +118,54 @@ struct ARROW_EXPORT AzureOptions {
MakeDataLakeServiceClient() const;
};
+namespace internal {
+
+enum class HNSSupport {
Review Comment:
Again I don't feel strongly, but I would not have abbreviated so much. Yes,
the docstring explains in detail but someone who just sees that name and
Googles "HNS" will find themselves learning about the [Croatian Football
Federation](https://en.wikipedia.org/wiki/Croatian_Football_Federation) :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]