lidavidm commented on code in PR #1383:
URL: https://github.com/apache/arrow-adbc/pull/1383#discussion_r1432741694


##########
docs/source/driver/postgresql.rst:
##########
@@ -188,6 +188,129 @@ PostgreSQL allows defining new types at runtime, so the 
driver must
 build a mapping of available types.  This is currently done once at
 startup.
 
-Type support is currently limited.  Parameter binding and bulk
-ingestion support int16, int32, int64, and string.  Reading result
-sets is limited to int32, int64, float, double, and string.
+Type support is currently limited depending on the type and whether it is
+being read or written.
+
+.. list-table:: Arrow type to PostgreSQL type mapping
+   :header-rows: 1
+
+   * - Arrow Type
+     - As Bind Parameter
+     - In Bulk Ingestion

Review Comment:
   Ah, I'm not sure what I was thinking. I can add the Postgres type for that 
as well. (Technically it gets resolved to an OID so it's not necessarily 
exactly that type name, I think, but would be the same.)
   
   And I would expect them to be the same just that it may not be supported in 
one or the other



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to