lidavidm commented on code in PR #1383: URL: https://github.com/apache/arrow-adbc/pull/1383#discussion_r1432746458
########## docs/source/driver/postgresql.rst: ########## @@ -188,6 +188,129 @@ PostgreSQL allows defining new types at runtime, so the driver must build a mapping of available types. This is currently done once at startup. -Type support is currently limited. Parameter binding and bulk -ingestion support int16, int32, int64, and string. Reading result -sets is limited to int32, int64, float, double, and string. +Type support is currently limited depending on the type and whether it is +being read or written. + +.. list-table:: Arrow type to PostgreSQL type mapping + :header-rows: 1 + + * - Arrow Type + - As Bind Parameter + - In Bulk Ingestion Review Comment: > (also, for the bind parameters, we do support passing the data as a pyarrow table/batch/stream. That can then also use different types?) No, whether you pass data as Python or PyArrow types, it all gets converted into PyArrow types ########## docs/source/driver/postgresql.rst: ########## @@ -188,6 +188,129 @@ PostgreSQL allows defining new types at runtime, so the driver must build a mapping of available types. This is currently done once at startup. -Type support is currently limited. Parameter binding and bulk -ingestion support int16, int32, int64, and string. Reading result -sets is limited to int32, int64, float, double, and string. +Type support is currently limited depending on the type and whether it is +being read or written. + +.. list-table:: Arrow type to PostgreSQL type mapping + :header-rows: 1 + + * - Arrow Type + - As Bind Parameter + - In Bulk Ingestion Review Comment: > (also, for the bind parameters, we do support passing the data as a pyarrow table/batch/stream. That can then also use different types?) No, whether you pass data as Python or PyArrow types, it all gets converted into PyArrow types and then by the driver into Postgres types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
