alamb commented on code in PR #8603:
URL: https://github.com/apache/arrow-datafusion/pull/8603#discussion_r1433055169
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1338,7 +1338,11 @@ pub fn parse_expr(
in_list.negated,
))),
ExprType::Wildcard(protobuf::Wildcard { qualifier }) =>
Ok(Expr::Wildcard {
- qualifier: qualifier.clone(),
+ qualifier: if qualifier.is_empty() {
Review Comment:
I think this is fine -- I don't think an empty string `""` is a valid
qualifier anyways so not being able to distinguish between `""` and `None` is
not important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
