edmondop commented on PR #8603:
URL: 
https://github.com/apache/arrow-datafusion/pull/8603#issuecomment-1866487613

   > @alamb The use of the `optional` keyword seems nicer, but this was the 
only place that we were using it, so it seems better to remove it and make it 
consistent with the rest of the file for now? The alternative is updating docs 
to require the use of a newer version of protoc, but I am not sure of the 
impact of that on downstream projects.
   
   Sorry for the late comment. I think it would be great if we align the 
version in the docs with the version used by CI/CD pipeline. Will submit a PR 
later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to