alamb commented on code in PR #8578: URL: https://github.com/apache/arrow-datafusion/pull/8578#discussion_r1433163133
########## docs/source/library-user-guide/adding-udfs.md: ########## @@ -93,6 +95,11 @@ let udf = create_udf( ); ``` +[`scalarudf`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.ScalarUDF.html Review Comment: For some reason this lower casing is done by `prettier` so I can't impmement this suggestion without causing CI to fail 😬 ```shell andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ git diff ``` ```diff diff --git a/docs/source/library-user-guide/adding-udfs.md b/docs/source/library-user-guide/adding-udfs.md index c51e4de32..1d2cc0a12 100644 --- a/docs/source/library-user-guide/adding-udfs.md +++ b/docs/source/library-user-guide/adding-udfs.md @@ -95,7 +95,7 @@ let udf = create_udf( ); -[`scalarudf`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.ScalarUDF.html +[`ScalarUDF`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.ScalarUDF.html [`create_udf`]: https://docs.rs/datafusion/latest/datafusion/logical_expr/fn.create_udf.html [`make_scalar_function`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/functions/fn.make_scalar_function.html [`advanced_udf.rs`]: https://github.com/apache/arrow-datafusion/blob/main/datafusion-examples/examples/advanced_udf.rs ``` ```shell andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ npx [email protected] --check '{datafusion,datafusion-cli,datafusion-examples,dev,docs}/**/*.md' '!datafusion/CHANGELOG.md' README.md CONTRIBUTING.md Checking formatting... [warn] docs/source/library-user-guide/adding-udfs.md [warn] Code style issues found in the above file. Forgot to run Prettier? andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ git reset --hard HEAD is now at 3ce1802df Improve docs for aliases andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ npx [email protected] --check '{datafusion,datafusion-cli,datafusion-examples,dev,docs}/**/*.md' '!datafusion/CHANGELOG.md' README.md CONTRIBUTING.md Checking formatting... All matched files use Prettier code style! andrewlamb@Andrews-MacBook-Pro:~/Software/arrow-datafusion$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
