davisusanibar commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1434374248
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/DefaultAllocationManagerOption.java:
##########
@@ -61,6 +64,7 @@ public enum AllocationManagerType {
Unknown,
}
+ @SuppressWarnings("nullness:argument") //enum types valueOf are implicitly
non-null
Review Comment:
I tried to do that, but this change produced other errors as well.
```
arrow-memory-core: Compilation failure: Compilation failure:
[ERROR]
/arrow/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[76,34]
error: [return] incompatible types in return.
[ERROR] type of expression: @Initialized @Nullable Object
[ERROR] method return type: @Initialized @NonNull Object
[ERROR]
/arrow/java/memory/memory-core/src/main/java/org/apache/arrow/memory/DefaultAllocationManagerOption.java:[73,42]
error: [argument] incompatible argument for parameter name of
AllocationManagerType.valueOf.
[ERROR] found : @Initialized @Nullable String
[ERROR] required: @Initialized @NonNull String
[ERROR]
/arrow/java/memory/memory-core/src/main/java/org/apache/arrow/memory/DefaultAllocationManagerOption.java:[81,42]
error: [argument] incompatible argument for parameter name of
AllocationManagerType.valueOf.
[ERROR] found : @Initialized @Nullable String
[ERROR] required: @Initialized @NonNull String
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
