davisusanibar commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1434376718
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/hash/SimpleHasher.java:
##########
@@ -110,7 +111,7 @@ public int hashCode() {
}
@Override
- public boolean equals(Object obj) {
+ public boolean equals(@Nullable Object obj) {
Review Comment:
If it is certain that it will never be null, then any annotations need to be
added. When there are logic/circuit/steps that can be null or not, then
Nullable is needed (that does not mean that it is always null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
