zanmato1984 commented on issue #36246: URL: https://github.com/apache/arrow/issues/36246#issuecomment-1866980969
> IIUC, the question is about removing `function.h` from `api.h` and including it in `api_xxx.h` where `xxx` is a function name. I'm OK with that yes. This kind of thing is not uncommon. The question is actually opposite. The header `function.h` remains in `compute/api.h`, with and without this PR. The proposed PR removes `function.h` from `api_xxx.h` (then includes `options.h` instead), as proposed in the initial description of this issue. This results in compile failures for user code which includes only `compute/api_xxx.h` but not `compute/api.h`, and meanwhile uses `CallFunction` which is declared in `function.h`. @felipecrv would you please help to confirm again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
