zanmato1984 commented on issue #36246: URL: https://github.com/apache/arrow/issues/36246#issuecomment-1864926821
> > Sorry but I think you meant `compute/api_xxx.h`, so that legacy user code in the above pattern doesn't break? `CallFunction` is in `compute/api.h` already. > > Well, that also depends if we can make `function.h` cheap enough :-) I think what we were talking about is to NOT make legacy user code fail compiling, i.e., "unknown `CallFunction`". To do that, we must keep `function.h` within `compute/api_xxx.h`. You were mentioning `compute/api.h` in your second last comment, but `compute/api.h` has `function.h` already even in my PR. So I just wanted to make sure that you were suggesting we should keep `function.h` in `compute/api_xxx.h` rather than `compute/api.h`. So how does "whether `function.h` is cheap enough" relate to above? Sorry again I'm not really following so I appreciate any clearance. Thanks @pitrou ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
