WillAyd commented on code in PR #1393:
URL: https://github.com/apache/arrow-adbc/pull/1393#discussion_r1434574632
##########
c/driver/postgresql/statement.cc:
##########
@@ -611,25 +605,26 @@ struct BindStream {
return ADBC_STATUS_IO;
}
- if (PQputCopyEnd(conn, NULL) <= 0) {
- SetError(error, "Error message returned by PQputCopyEnd: %s",
- PQerrorMessage(conn));
- return ADBC_STATUS_IO;
- }
+ if (rows_affected) *rows_affected += array->length;
Review Comment:
What we might want to do (certainly fine as a follow up) is send this data
to the server at the end of each loop iteration using `PQputCopyData`:
https://www.postgresql.org/docs/current/libpq-copy.html#LIBPQ-COPY-SEND
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
