lidavidm commented on code in PR #1393:
URL: https://github.com/apache/arrow-adbc/pull/1393#discussion_r1434590685
##########
c/driver/postgresql/statement.cc:
##########
@@ -611,25 +605,26 @@ struct BindStream {
return ADBC_STATUS_IO;
}
- if (PQputCopyEnd(conn, NULL) <= 0) {
- SetError(error, "Error message returned by PQputCopyEnd: %s",
- PQerrorMessage(conn));
- return ADBC_STATUS_IO;
- }
+ if (rows_affected) *rows_affected += array->length;
Review Comment:
Sorry, what do you mean? We're still calling PQputCopyData for each batch,
we're just not calling PQputCopyEnd until we've written *all* the batches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
