alamb commented on code in PR #8651:
URL: https://github.com/apache/arrow-datafusion/pull/8651#discussion_r1436435521
##########
datafusion-cli/src/print_format.rs:
##########
@@ -159,14 +191,41 @@ impl PrintFormat {
}
Ok(())
}
+
+ pub fn print_stream(&self, batch: &RecordBatch, with_header: bool) ->
Result<()> {
Review Comment:
Specifically, I think you could write the functions in terms of
`std::io::Write` and then pass in
https://doc.rust-lang.org/std/io/fn.stdout.html to avoid having to both copy
the code and the code could avoid copying strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
