berkaysynnada commented on PR #8651: URL: https://github.com/apache/arrow-datafusion/pull/8651#issuecomment-1869523201
> Thank you for this PR @berkaysynnada. I think it adds features that don't currently exist on main and thus is a step forward. > > I do think there is a bit of replicated code that could be avoided, but I don't think that is required. I left some suggestions on how to improve the code for your consideration, though I think we make them as follow on PRs as well. > > > Unbounded tables can now be displayed in the CLI using any format except PrintFormat::Table. Row limit is ignored while printing unbounded tables. > > In general this is a great idea. Thank you for your feedback. I will try to implement your suggestions, and also add a test by looking at existing examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
