tustvold commented on code in PR #5244:
URL: https://github.com/apache/arrow-rs/pull/5244#discussion_r1436458335
##########
object_store/src/aws/builder.rs:
##########
@@ -559,19 +556,25 @@ impl AmazonS3Builder {
Ok(())
}
- /// Set the AWS Access Key (required)
+ /// Set the AWS Access Key
pub fn with_access_key_id(mut self, access_key_id: impl Into<String>) ->
Self {
self.access_key_id = Some(access_key_id.into());
self
}
- /// Set the AWS Secret Access Key (required)
+ /// Set the AWS Secret Access Key
Review Comment:
This is a drive-by fix as these are no longer required (we support other
forms of credential)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
