tustvold commented on code in PR #5244:
URL: https://github.com/apache/arrow-rs/pull/5244#discussion_r1436458587
##########
object_store/src/aws/builder.rs:
##########
@@ -559,19 +556,25 @@ impl AmazonS3Builder {
Ok(())
}
- /// Set the AWS Access Key (required)
+ /// Set the AWS Access Key
pub fn with_access_key_id(mut self, access_key_id: impl Into<String>) ->
Self {
self.access_key_id = Some(access_key_id.into());
self
}
- /// Set the AWS Secret Access Key (required)
+ /// Set the AWS Secret Access Key
pub fn with_secret_access_key(mut self, secret_access_key: impl
Into<String>) -> Self {
self.secret_access_key = Some(secret_access_key.into());
self
}
- /// Set the region (e.g. `us-east-1`) (required)
+ /// Set the AWS Session Token to use for requests
+ pub fn with_token(mut self, token: impl Into<String>) -> Self {
Review Comment:
This is moved up from lower down, to sit alongside the credentials it
relates to. I also tweaked the doc to make it a bit clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
