my-vegetable-has-exploded commented on code in PR #8654:
URL: https://github.com/apache/arrow-datafusion/pull/8654#discussion_r1436863275
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -1105,13 +1100,18 @@ mod tests {
let data = bytes::Bytes::from(std::fs::read(path).unwrap());
// generate pruning predicate
- let schema = Schema::new(vec![
- Field::new("String", DataType::Utf8, false),
- Field::new("String3", DataType::Utf8, false),
- ]);
- let sql =
- "SELECT * FROM tbl WHERE \"String\" IN ('Hello_Not_Exists',
'Hello_Not_Exists2')";
- let expr = sql_to_physical_plan(sql).unwrap();
Review Comment:
This previous test relied on the optimizer who will convert `in_list` expr
with no more 3 elements to `and` expr. Now we don't need this.
`logical2physical` would convert `logical_expr` to `physical_expr` without
optimizer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
