waynexia commented on code in PR #8654:
URL: https://github.com/apache/arrow-datafusion/pull/8654#discussion_r1437103480
##########
datafusion/physical-expr/src/utils/guarantee.rs:
##########
@@ -130,6 +124,39 @@ impl LiteralGuarantee {
.fold(GuaranteeBuilder::new(), |builder, expr| {
if let Some(cel) = ColOpLit::try_new(expr) {
return builder.aggregate_conjunct(cel);
+ } else if let Some(inlist) = expr
+ .as_any()
+ .downcast_ref::<crate::expressions::InListExpr>()
+ {
+ //Only support single-column inlist currently,
multi-column inlist is not supported
Review Comment:
nit:
```suggestion
// Only support single-column inlist currently,
multi-column inlist is not supported
```
##########
datafusion/physical-expr/src/utils/guarantee.rs:
##########
@@ -120,7 +114,7 @@ impl LiteralGuarantee {
/// expression is guaranteed to be `null` or `false`.
///
/// # Notes:
- /// 1. `expr` must be a boolean expression.
+ /// 1. `expr` must be a boolean expression or inlist expression.
Review Comment:
More specifically, the boolean expr can only be in a form that can be
transformed into a `ColOpLit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
