jdye64 commented on code in PR #550:
URL:
https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437834313
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a
multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
I don't think directly. I will say having lots of these "(crate)" level
visibility of structs makes using ADP as a library difficult since they are not
visible outside the crate. I had started removing them awhile back and think
Andy was just removing another one of them. I should probably just make a PR to
remove them all, where it makes sense of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
