andygrove commented on code in PR #550:
URL:
https://github.com/apache/arrow-datafusion-python/pull/550#discussion_r1437856266
##########
src/dataframe.rs:
##########
@@ -36,7 +36,7 @@ use std::sync::Arc;
/// The actual execution of a plan runs natively on Rust and Arrow on a
multi-threaded environment.
#[pyclass(name = "DataFrame", module = "datafusion", subclass)]
#[derive(Clone)]
-pub(crate) struct PyDataFrame {
+pub struct PyDataFrame {
Review Comment:
I removed the `(crate)` restriction to work around many warnings like the
following. I wonder if this was caused by a recent Rust version upgrade rather
than anything related to 34.0.0.
```
warning: type `PyDataFrame` is more private than the item
`PySessionContext::sql`
--> src/context.rs:282:5
|
282 | pub fn sql(&mut self, query: &str, py: Python) ->
PyResult<PyDataFrame> {
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method
`PySessionContext::sql` is reachable at visibility `pub`
|
note: but type `PyDataFrame` is only usable at visibility `pub(crate)`
--> src/dataframe.rs:39:1
|
39 | pub(crate) struct PyDataFrame {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
