alamb commented on PR #8666: URL: https://github.com/apache/arrow-datafusion/pull/8666#issuecomment-1871454311
> LGTM but having one more reviewer would be good to make sure we are not losing any performance due to allocation-related reasons Since the previous version of the code was `cloning` the serializer anyway and the API returns `Bytes` (a read only structure) I don't think this PR is doing more allocations than before. Arguably it is better in that it is clearer now how allocations are performed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
