ozankabak commented on code in PR #8666:
URL: https://github.com/apache/arrow-datafusion/pull/8666#discussion_r1437875792
##########
datafusion/core/src/datasource/file_format/write/mod.rs:
##########
@@ -149,15 +145,14 @@ impl<W: AsyncWrite + Unpin + Send> AsyncWrite for
AbortableWrite<W> {
/// A trait that defines the methods required for a RecordBatch serializer.
#[async_trait]
-pub trait BatchSerializer: Unpin + Send {
+pub trait SerializationSchema: Sync + Send {
/// Asynchronously serializes a `RecordBatch` and returns the serialized
bytes.
- async fn serialize(&mut self, batch: RecordBatch) -> Result<Bytes>;
- /// Duplicates self to support serializing multiple batches in parallel on
multiple cores
- fn duplicate(&mut self) -> Result<Box<dyn BatchSerializer>> {
- Err(DataFusionError::NotImplemented(
- "Parallel serialization is not implemented for this file
type".into(),
- ))
- }
+ async fn serialize(&self, batch: RecordBatch) -> Result<Bytes>;
Review Comment:
I think your suggestion is a better pattern and I will send a commit to
incorporate it shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
