korowa commented on code in PR #8658:
URL: https://github.com/apache/arrow-datafusion/pull/8658#discussion_r1437874860
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1611,9 +1628,9 @@ mod tests {
async fn join_inner_one_no_shared_column_names() -> Result<()> {
let task_ctx = Arc::new(TaskContext::default());
let left = build_table(
- ("a1", &vec![1, 2, 3]),
+ ("a1", &vec![1, 3, 2]),
Review Comment:
It's a miss -- the plan was to modify first test for inner join so that the
output wouldn't not be equal to sorted output -- I'll better just revert this
change and will add separate test with randomly sorted input -- like this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
