korowa commented on PR #8658: URL: https://github.com/apache/arrow-datafusion/pull/8658#issuecomment-1871932515
> However, are the JoinHashMap struct comments relevant after this change? @metesynnada, yes, the PR is only related to the JoinHashMap input -- all its internals remains as they were before so all docs and comments for both JoinHashMap and moved pieces of code are still relevant. The only comment modification is related to missing `offset` argument in `update_from_iter` as its caller responsibility to provide correct row indices in iterator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
