roeap commented on code in PR #5259:
URL: https://github.com/apache/arrow-rs/pull/5259#discussion_r1438407652
##########
object_store/src/azure/credential.rs:
##########
@@ -24,26 +24,27 @@ use crate::RetryConfig;
use async_trait::async_trait;
use base64::prelude::BASE64_STANDARD;
use base64::Engine;
-use chrono::{DateTime, Utc};
-use reqwest::header::ACCEPT;
-use reqwest::{
- header::{
- HeaderMap, HeaderName, HeaderValue, AUTHORIZATION, CONTENT_ENCODING,
CONTENT_LANGUAGE,
- CONTENT_LENGTH, CONTENT_TYPE, DATE, IF_MATCH, IF_MODIFIED_SINCE,
IF_NONE_MATCH,
- IF_UNMODIFIED_SINCE, RANGE,
- },
- Client, Method, RequestBuilder,
+use chrono::{DateTime, SecondsFormat, Utc};
+use reqwest::header::{
+ HeaderMap, HeaderName, HeaderValue, ACCEPT, AUTHORIZATION,
CONTENT_ENCODING, CONTENT_LANGUAGE,
+ CONTENT_LENGTH, CONTENT_TYPE, DATE, IF_MATCH, IF_MODIFIED_SINCE,
IF_NONE_MATCH,
+ IF_UNMODIFIED_SINCE, RANGE,
};
+use reqwest::{Client, Method, Request, RequestBuilder};
use serde::Deserialize;
use snafu::{ResultExt, Snafu};
use std::borrow::Cow;
+use std::collections::HashMap;
+use std::fmt::Debug;
use std::process::Command;
use std::str;
use std::sync::Arc;
use std::time::{Duration, Instant, SystemTime};
use url::Url;
-static AZURE_VERSION: HeaderValue = HeaderValue::from_static("2021-08-06");
+use super::client::UserDelegationKey;
+
+static AZURE_VERSION: HeaderValue = HeaderValue::from_static("2023-11-03");
Review Comment:
Bumping the azure API version should not be breaking any users I think.
##########
object_store/src/azure/client.rs:
##########
@@ -757,8 +817,7 @@ mod tests {
<NextMarker/>
</EnumerationResults>";
- let mut _list_blobs_response_internal: ListResultInternal =
- quick_xml::de::from_str(S).unwrap();
+ let _list_blobs_response_internal: ListResultInternal =
quick_xml::de::from_str(S).unwrap();
Review Comment:
drive by: remove unnecessary `mut`
##########
object_store/src/azure/credential.rs:
##########
@@ -137,33 +141,47 @@ pub mod authority_hosts {
pub const AZURE_PUBLIC_CLOUD: &str = "https://login.microsoftonline.com";;
}
-pub(crate) trait CredentialExt {
- /// Apply authorization to requests against azure storage accounts
- ///
<https://docs.microsoft.com/en-us/rest/api/storageservices/authorize-requests-to-azure-storage>
- fn with_azure_authorization(self, credential: &AzureCredential, account:
&str) -> Self;
+/// Authorize a [`Request`] with an [`AzureAuthorizer`]
+#[derive(Debug)]
+pub struct AzureAuthorizer<'a> {
Review Comment:
Initially I wanted this to look more like AWS and I expected more shared
code between "regular" url signing for requests and generating SAS tokens.
In practice these functionalities could probably be separate, but kept it to
be more in line with AWS.
If users would want to create multiple signed URLs with a user delegated
key, they would use `AzureAuthorizer` and previously acquire a user delegated
key via the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
