tustvold commented on code in PR #5259:
URL: https://github.com/apache/arrow-rs/pull/5259#discussion_r1441826623
##########
object_store/src/signer.rs:
##########
@@ -30,5 +30,21 @@ pub trait Signer: Send + Sync + fmt::Debug + 'static {
/// the URL should be valid, return a signed [`Url`] created with the
object store
/// implementation's credentials such that the URL can be handed to
something that doesn't have
/// access to the object store's credentials, to allow limited access to
the object store.
- async fn signed_url(&self, method: Method, path: &Path, expires_in:
Duration) -> Result<Url>;
+ async fn signed_url(&self, method: &Method, path: &Path, expires_in:
Duration) -> Result<Url>;
Review Comment:
I think I would prefer to avoid making this breaking change, in practice
Method should be basically free to clone, and regardless it will be cheaper
than the cost of the signing computation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
