Jefffrey commented on code in PR #5260:
URL: https://github.com/apache/arrow-rs/pull/5260#discussion_r1438732894
##########
arrow-schema/src/datatype.rs:
##########
@@ -23,14 +23,18 @@ use crate::{Field, FieldRef, Fields, UnionFields};
/// The set of datatypes that are supported by this implementation of Apache
Arrow.
///
/// The Arrow specification on data types includes some more types.
-/// See also
[`Schema.fbs`](https://github.com/apache/arrow/blob/master/format/Schema.fbs)
+/// See also
[`Schema.fbs`](https://github.com/apache/arrow/blob/main/format/Schema.fbs)
Review Comment:
Current link works but shows popup everytime:
So just change to main
##########
arrow-schema/src/datatype.rs:
##########
@@ -147,8 +151,10 @@ pub enum DataType {
/// in milliseconds (64 bits). Values are evenly divisible by 86400000.
Date64,
/// A 32-bit time representing the elapsed time since midnight in the unit
of `TimeUnit`.
+ /// Must be either seconds or millieseconds.
Time32(TimeUnit),
/// A 64-bit time representing the elapsed time since midnight in the unit
of `TimeUnit`.
+ /// Must be either microseconds or nanoseconds.
Time64(TimeUnit),
Review Comment:
Want to be explicit here as in isolation it can imply Time64 could take on
seconds/milliseconds and Time32 could take on microseconds/nanoseconds based on
TimeUnit enum alone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
