alamb commented on code in PR #5260:
URL: https://github.com/apache/arrow-rs/pull/5260#discussion_r1438878010
##########
arrow-schema/src/datatype.rs:
##########
@@ -140,15 +144,17 @@ pub enum DataType {
/// DataType::Timestamp(TimeUnit::Second,
Some("string".to_string().into()));
/// ```
Timestamp(TimeUnit, Option<Arc<str>>),
- /// A 32-bit date representing the elapsed time since UNIX epoch
(1970-01-01)
+ /// A signed 32-bit date representing the elapsed time since UNIX epoch
(1970-01-01)
/// in days (32 bits).
Date32,
- /// A 64-bit date representing the elapsed time since UNIX epoch
(1970-01-01)
+ /// A signed 64-bit date representing the elapsed time since UNIX epoch
(1970-01-01)
/// in milliseconds (64 bits). Values are evenly divisible by 86400000.
Date64,
- /// A 32-bit time representing the elapsed time since midnight in the unit
of `TimeUnit`.
+ /// A signed 32-bit time representing the elapsed time since midnight in
the unit of `TimeUnit`.
+ /// Must be either seconds or millieseconds.
Review Comment:
```suggestion
/// Must be either seconds or milliseconds.
```
##########
arrow-schema/src/datatype.rs:
##########
@@ -23,14 +23,18 @@ use crate::{Field, FieldRef, Fields, UnionFields};
/// The set of datatypes that are supported by this implementation of Apache
Arrow.
///
/// The Arrow specification on data types includes some more types.
-/// See also
[`Schema.fbs`](https://github.com/apache/arrow/blob/master/format/Schema.fbs)
+/// See also
[`Schema.fbs`](https://github.com/apache/arrow/blob/main/format/Schema.fbs)
/// for Arrow's specification.
///
/// The variants of this enum include primitive fixed size types as well as
parametric or
/// nested types.
-/// Currently the Rust implementation supports the following nested types:
+/// Currently the Rust implementation supports the following nested types:
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
