jorgecarleitao commented on a change in pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#discussion_r563160480
##########
File path: rust/arrow/src/compute/kernels/take.rs
##########
@@ -1350,20 +1532,32 @@ mod tests {
}
#[test]
- #[should_panic(
- expected = "Array index out of bounds, cannot get item at index 6 from
5 entries"
- )]
fn test_take_out_of_bounds() {
let index = UInt32Array::from(vec![Some(3), None, Some(1), Some(3),
Some(6)]);
let take_opt = TakeOptions { check_bounds: true };
// int64
- test_take_primitive_arrays::<Int64Type>(
+ let result = test_take_primitive_arrays::<Int64Type>(
vec![Some(0), None, Some(2), Some(3), None],
&index,
Some(take_opt),
vec![None],
);
+ assert!(result.is_err());
+ }
+
+ #[test]
+ #[should_panic(expected = "index out of bounds: the len is 4 but the index
is 1000")]
+ fn test_take_out_of_bounds_panic() {
Review comment:
this was not passing in master, this is the one that should panic...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
