jorgecarleitao commented on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766157047
@Dandandan , > Wouldn't it be possible to have a similar as previously implementation for `take_no_nulls` and `take_values_nulls`? I think those are the most common anyway. I am sorry, I did not understand: this PR does split the kernel in the 4 cases, and uses them accordingly depending on the null count of `values` and `indices`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org